From 478871d2c4a2e572097b7f686dadd41f43bd2c5a Mon Sep 17 00:00:00 2001 From: David Gibson Date: Tue, 18 Aug 2015 06:06:09 +0200 Subject: [PATCH 3/3] RHEL: Suppress scary but unimportant errors for KVM VFIO on powerpc Message-id: <1439877969-12704-1-git-send-email-dgibson@redhat.com> Patchwork-id: 67563 O-Subject: [RHEL7.2 qemu-kvm-rhev PATCH] RHEL: Suppress scary but unimportant errors for KVM VFIO on powerpc Bugzilla: 1237034 RH-Acked-by: Laurent Vivier RH-Acked-by: Miroslav Rezanina RH-Acked-by: Thomas Huth The current downstream qemu VFIO code produces an error message if a vfio device is requested, but it can't create the KVM VFIO device in the kernel. This error is important for x86, because the kvm-vfio device is necessary to avoid potential coherency problems. For Power, however, the in-kernel device is unnecessary and not currently built. We're working upstream to enable the pseudo device for Power, but in the meantime, suppress the alarming but harmless error message in qemu. Upstream: downstream only patch Signed-off-by: David Gibson Signed-off-by: Miroslav Rezanina --- hw/vfio/common.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index b012620..6155e73 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -566,6 +566,14 @@ static void vfio_kvm_device_add_group(VFIOGroup *group) }; if (kvm_vm_ioctl(kvm_state, KVM_CREATE_DEVICE, &cd)) { +#if defined(TARGET_PPC) || defined(TARGET_PPC64) + /* RHEL: powerpc doesn't currently need or implement the + * KVM VFIO device. We plan to enable it eventually but + * for now suppress the scary error message if we fail to + * initialize the pseudo-device */ + if (errno == ENODEV) + return; +#endif error_report("Failed to create KVM VFIO device: %m"); return; } -- 1.8.3.1