From 1447c9ac143fb36f0c0f5a2974eac4d946d58538 Mon Sep 17 00:00:00 2001 Message-Id: <1447c9ac143fb36f0c0f5a2974eac4d946d58538.1367947969.git.minovotn@redhat.com> In-Reply-To: <707b9b97153063374d2530e72c49b1499fc21af9.1367947969.git.minovotn@redhat.com> References: <707b9b97153063374d2530e72c49b1499fc21af9.1367947969.git.minovotn@redhat.com> From: Michal Novotny Date: Tue, 7 May 2013 18:37:14 +0200 Subject: [PATCH 027/114] Revert "qemu-ga: Plug fd leak on ga_channel_open() error paths" This reverts commit e9f0fb11dcb0347def7e0080aec90cc614edbef0. Reverting as asked by Laszlo in message <51892739.2030807@redhat.com> because of the ordering issue (most likely) related to supersed testing. Signed-off-by: Michal Novotny --- qga/channel-posix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qga/channel-posix.c b/qga/channel-posix.c index 53dc044..2a1fe03 100644 --- a/qga/channel-posix.c +++ b/qga/channel-posix.c @@ -154,7 +154,6 @@ static gboolean ga_channel_open(GAChannel *c, const gchar *path, GAChannelMethod ret = ga_channel_client_add(c, fd); if (ret) { g_critical("error adding channel to main loop"); - close(fd); return false; } break; -- 1.7.11.7